Bugfix: enums from external fragments were not generated along with operations #10565

ikusakov2 · 2026-01-07T20:25:41Z

Description

This PR includes the fix to the following issue: enums from external fragment were not copied to the generated file along with operations.

Additionally, an integrated test is added:
dev-test-apollo-tooling
That mimics the Apollo-tooling setup.

Testing

Unit tests

changeset-bot · 2026-01-07T20:32:27Z

🦋 Changeset detected

Latest commit: 3839b02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphql-codegen/typescript-operations	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…config-extractAllFieldsToTypesCompact

eddeee888 · 2026-01-08T12:24:44Z

packages/plugins/typescript/operations/src/visitor.ts

+    const documentWithExternalFragments: DocumentNode = {
+      ...documentNode,
+      definitions: [...documentNode.definitions, ...(config.externalFragments || []).map(f => f.node)],
+    };


I wonder if the functionality in the above statement used to create allFragments could be used for our fragments here somehow? 🤔
It seems to do a similar function of collecting fragments, either from documents or from config.

Good call!
Check the new code - I combined it with allFragments.

eddeee888 · 2026-01-08T12:28:45Z

dev-test-alpha/.gitignore

@@ -0,0 +1,2 @@
+**/__generated__/**


I feel we should unignore the generation 🙂
This could be a good test that can be kept as snapshot test, and an advanced use case of codegen

OK, generated files added!

ikusakov2 · 2026-01-08T20:08:20Z

dev-test-alpha/cli/index.ts

@@ -0,0 +1,106 @@
+#!/usr/bin/env ts-node


I created the dev-test-alpha just as a temporary package to demonstrate our company issues.
Do you think it would be worth keeping it?
Then:

I'll need to add some tests which would get invoked when global tests are running.

We need to come up with some better name than dev-test-alpha

Yes, I think so! I find this test is very valuable, as it can be used to catch unexpected bugs, at least in the initial stage after rolling out.

I feel we might be able to simplify a few things in the setup. And worst case, if its usefulness is overshadowed by maintenance, we can decide to drop it (or further simplify) later 🙂

OK, I renamed dev-test-alpha to dev-test-apollo-tooling - to give a more descriptive name to what this integration test it about. I also added another (hopefully last) fix - so you can run yarn install && yarn build from the root directory: graphql-code-generator and - it should work.

ikusakov2 · 2026-01-08T20:14:12Z

dev-test-alpha/src/__generated__/Component.ts

+// @generated
+// This file was automatically generated and should not be edited.
+
+import type * as Types from '../../graphql-code-generator/dev-test-alpha/src/__generated__/globalTypes';


I think we already worked on removing this line in typescript-operations plugin.
But it probably comes from near-operation-file preset.
Shall we ignore it until we do the next version of near-operation-file?

I did a research and - yes, it comes from near-operation-file.

ikusakov2 · 2026-01-08T20:14:49Z

dev-test-alpha/src/__generated__/Component.ts

+
+type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
+export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
+export enum UserManagerRoleType {


With the recent fix - it adds the enum in the correct file.

…config-extractAllFieldsToTypesCompact

eddeee888 · 2026-01-13T09:48:26Z

dev-test-apollo-tooling/cli/index.ts

+ * @see https://github.com/apollographql/apollo-tooling/issues/2053
+ * */
+const GRAPHQL_CODEGEN_CONFIG = {
+  skipTypename: false,


This config doesn't exist anymore 🙂

eddeee888 · 2026-01-13T09:48:49Z

dev-test-apollo-tooling/cli/index.ts

+const GRAPHQL_CODEGEN_CONFIG = {
+  skipTypename: false,
+  useTypeImports: true,
+  preResolveTypes: true, // Simplifies the generated types


preResolveTypes: true is the only option now, and it's been removed entirely.
So we can omit it (when we are ready to merge)

eddeee888 · 2026-01-13T09:53:59Z

dev-test-apollo-tooling/src/__generated__/Helper.ts

+
+import type * as Types from '../unused';
+
+type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };


(Context/braindump, not a comment on this PR)

I made a TODO about Exact being generated but not used in files with only fragments in the feature PR. Some users' tsconfig.json may have strict types so it'd fail tsc.

I believe we are generating Exact all the time, but we should only do it if operations have been found in a document. I can take a look into that in a different PR.

eddeee888 · 2026-01-13T09:56:12Z

package.json

    "typescript": "5.5.4",
-    "eslint-plugin-promise": "7.1.0"
+    "eslint-plugin-promise": "7.1.0",
+    "graphql": "16.9.0"


I think resolving a particular version of graphql is usually done in CI, when we test multiple versions of GraphQL in different actions.

Do we need this for this PR? 🙂

integration test

6616585

ikusakov2 changed the title ~~An intergration test showing errors with recent alpha version~~ An integration test showing errors with recent alpha version Jan 7, 2026

ikusakov2 changed the base branch from master to master-next January 7, 2026 20:27

cleanups

7e204c1

ikusakov added 3 commits January 7, 2026 15:33

cleanups2

2fc4571

Merge remote-tracking branch 'upstream/master-next' into feature/add-…

056dbd0

…config-extractAllFieldsToTypesCompact

fixed a bug with external fragments

ba85977

ikusakov2 marked this pull request as ready for review January 7, 2026 22:03

cleanup

6fd5428

eddeee888 reviewed Jan 8, 2026

View reviewed changes

keep generated files, refactored visitorwq

790b876

ikusakov2 commented Jan 8, 2026

View reviewed changes

cleanup

e73b9ba

ikusakov2 closed this Jan 8, 2026

ikusakov2 deleted the feature/add-config-extractAllFieldsToTypesCompact branch January 8, 2026 23:00

ikusakov2 restored the feature/add-config-extractAllFieldsToTypesCompact branch January 8, 2026 23:02

ikusakov2 reopened this Jan 8, 2026

ikusakov added 3 commits January 8, 2026 19:52

changeset

1f54f42

adding missing dependency

900aa10

delete temporary files

10a2774

ikusakov2 changed the title ~~An integration test showing errors with recent alpha version~~ Fixing an issue with including enums from external fragments Jan 12, 2026

ikusakov added 2 commits January 12, 2026 17:01

cleanup

10d3b85

cleanups

9b3dbf8

ikusakov2 changed the title ~~Fixing an issue with including enums from external fragments~~ Bugfix: enums from external fragments were not generated along with operations Jan 12, 2026

ikusakov added 2 commits January 12, 2026 17:27

Adding back the integration tests + fix them

64b7834

Merge remote-tracking branch 'upstream/master-next' into feature/add-…

17c9614

…config-extractAllFieldsToTypesCompact

ikusakov added 3 commits January 12, 2026 17:37

merged + fixes

ab0ab18

cleanup

1498d8f

cleanup

3839b02

eddeee888 reviewed Jan 13, 2026

View reviewed changes


		import type * as Types from '../unused';

		type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };

Bugfix: enums from external fragments were not generated along with operations #10565

Are you sure you want to change the base?

Bugfix: enums from external fragments were not generated along with operations #10565

Uh oh!

Conversation

ikusakov2 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

changeset-bot bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikusakov2 Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ikusakov2 commented Jan 7, 2026 •

edited

Loading

changeset-bot bot commented Jan 7, 2026 •

edited

Loading

eddeee888 Jan 11, 2026 •

edited

Loading

ikusakov2 Jan 8, 2026 •

edited

Loading

eddeee888 Jan 13, 2026 •

edited

Loading

eddeee888 Jan 13, 2026 •

edited

Loading

eddeee888 Jan 13, 2026 •

edited

Loading